Skip to content

[DOP-21799] Refactor celery initialization #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 10, 2024
Merged

[DOP-21799] Refactor celery initialization #165

merged 6 commits into from
Dec 10, 2024

Conversation

IlyasDevelopment
Copy link
Contributor

@IlyasDevelopment IlyasDevelopment commented Dec 9, 2024 •
edited
Loading

Change Summary

  • Moved Celery instances to separate backend, worker and scheduler modules
  • Removed unnecessary variable definitions from docs/conf.py

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment added the ci:skip-changelog Add this label to skip changelog file check label Dec 9, 2024
@IlyasDevelopment IlyasDevelopment self-assigned this Dec 9, 2024
@IlyasDevelopment IlyasDevelopment marked this pull request as ready for review December 9, 2024 14:14
dolfinus
dolfinus reviewed Dec 9, 2024
View reviewed changes
dolfinus
dolfinus reviewed Dec 10, 2024
View reviewed changes
dolfinus
dolfinus reviewed Dec 10, 2024
View reviewed changes
@IlyasDevelopment IlyasDevelopment merged commit 7a36705 into develop Dec 10, 2024
19 checks passed
@IlyasDevelopment IlyasDevelopment deleted the feature/DOP-21799 branch December 10, 2024 10:36
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (60ab590) to head (ad54a47).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@      Coverage Diff       @@
##   develop   #165   +/-   ##
==============================
==============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolfinus dolfinus dolfinus approved these changes

@maxim-lixakov maxim-lixakov Awaiting requested review from maxim-lixakov

Assignees

@IlyasDevelopment IlyasDevelopment

Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IlyasDevelopment @dolfinus